fix coalesce stream in FLV transmuxer to account for missing audio data in pending tracks #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjneil
force-pushed
the
flash-coalesce
branch
from
0c6b9ca
to
c917791
Compare
mjneil
changed the title
|
Looks good, though it would be good to have some unit tests. |
|
Looks good to me. |
aN0obIs
pushed a commit
to aN0obIs/mux.js
that referenced
this pull request
Apr 28, 2017
…ta in pending tracks (videojs#125) * fix coalesce stream to account for missing audio data in pending tracks * add test for emitting done event
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is an audio and video track in the segment but no audio data, (seen in several playlists with alternate audio tracks and no audio present in the main TS segments.), the
CoalesceStreamwould never finish its flush process and emit adoneevent. This would cause the player to become stuck waiting to append to the buffer, with no errors.This change accounts for this possibility and allows
CoalesceStreamto complete its flush cycle with an empty audio track. I also pulledCoalesceStreamout into its own file to help work towards needed project maintenance .