Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chapter Menu is Not Working in 4.12 #2131

Closed
stuartmcgarrity opened this issue May 7, 2015 · 8 comments
Closed

Chapter Menu is Not Working in 4.12 #2131

stuartmcgarrity opened this issue May 7, 2015 · 8 comments

Comments

@stuartmcgarrity
Copy link

If I specify video-js version 4.7 to 4.11 I see the chapter menu (bubble icon on control bar), but if I specify 4.12 the chapter menu is not there.

For example, change the video-js version in this example: http://jsbin.com/gotoma/4/edit?html,output

Stuart

@heff
Copy link
Member

heff commented May 8, 2015

We did a major overhaul on the track support in the most recent version, and it's possible we missed an issue. I'm on a plane so not in the best place to test things right now, but I see a few things.

  • An error reading "Cross-origin text track load denied by Cross-Origin Resource Sharing policy"
    It's possible the CORS settings need to be changed on the chapters file. We switched to using the browsers built-in track support, so that could be part of the change.
  • The chapters file in that example has varying timestamp formatting. The first cue uses a decimal. Others have two or three trailing zeros. I'm not sure what specifically of that might be wrong, but we switched VTT parsers (either uses the browser or VTT.js parsing), so what we have now might be pickier.
Chapter 1
 00:00:00:00 --> 00:00:02.000
Introduction

Chapter 2
 00:00:04:000 --> 00:00:08:00
Building a Model

 Chapter 3
 00:00:10:000 --> 00:00:12:00
Simulating the Model 

 Chapter 5
 00:00:14:000 --> 00:00:16:00
Conclusions

@gkatsev any thing else that might have change how chapters work?

@stuartmcgarrity
Copy link
Author

I made the timestamps consistent, but it still doesn't seem to work in video-js 4.12.

However the chapter menu sometimes appears with the Brightcove player: http://jsbin.com/yelaje/3/edit?html,output , but the chapters are duplicated. Its seems unreliable.

@gkatsev
Copy link
Member

gkatsev commented May 8, 2015

I think the issue here might be related to the crossorigin property of the video element. See #1888.

@stuartmcgarrity
Copy link
Author

I tried setting the property of the video element:

<video id="example_video_1" class="video-js vjs-default-skin"
crossorigin="anonymous"
controls preload="auto" width="640" height="264"

Is that correct?

The video failed to load in all browsers. In IE the poster did not load and
in Chrome there was an error message on the poster.

On Fri, May 8, 2015 at 4:58 PM, Gary Katsevman [email protected]
wrote:

I think the issue here might be related to the crossorigin property of
the video element. See #1888
#1888.


Reply to this email directly or view it on GitHub
#2131 (comment).

@gingerpad
Copy link

Did this issues ever get resolved. I have spent the morning trying to get chapters working in 4.12 to no avail.

However stumbling across this post, I tried 4.11 and chapters showed up straight away.

Is there a bug in 4.12 that is stopping chapters working as I am resistant to revert back to a 4.11 version for a customer that has been using 4.12

Further tests are showing that the dev version seems to be working fine, but the minified version does not

@christophelimpalair
Copy link

+1. Subtitles work but I cannot get Chapters to work in 4.12

@OwenEdwards
Copy link
Member

@gingerpad & @christophelimpalair, have you tried using the un-minified video.dev.js, instead of video.js? As @heff mentioned, there are CORS issues if the files are cross-domain and the formatting is more strict with the new VTT parser; but given that @christophelimpalair mentions that subtitles do work, I thought it might be relevant that I personally found that chapters don't seem to work with the minified version of video.js in 4.12.

@gkatsev
Copy link
Member

gkatsev commented Nov 17, 2015

Closing this for now. @chemoish is working on revamping our chapters support in #2804

@gkatsev gkatsev closed this as completed Nov 17, 2015
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants