Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emulate HTMLTrackElement to enable load event. #2804

Closed
wants to merge 20 commits into from
Closed

Emulate HTMLTrackElement to enable load event. #2804

wants to merge 20 commits into from

Commits on Dec 7, 2015

  1. Implement HTMLTrackElement shim. 

    - Add communication between emulated `HTMLTrackElement` and corresponding emulated `TextTrack`
- Followed `TextTrack` shim
    Carey Hinoki committed Dec 7, 2015
    Configuration menu
    Copy the full SHA
    448d2ff View commit details
    Browse the repository at this point in the history

  2. Implemented HTMLTrackElementList manage HTMLTrackElement and emul… 

    …ated `HTMLTrackELement`.

- Followed `TextTrackList` shim
    Carey Hinoki committed Dec 7, 2015
    Configuration menu
    Copy the full SHA
    3123de0 View commit details
    Browse the repository at this point in the history

  3. Fix issue of triggering removetrack event regardless if track was… 

    … found. Formatting.
    Carey Hinoki committed Dec 7, 2015
    Configuration menu
    Copy the full SHA
    86b97cf View commit details
    Browse the repository at this point in the history

  4. Added additional loadeddata event—originally defined by @OwenEdwards … 

    …in videojs#1949.

- Refactor `parseCue` to be managed by `loadTrack` so that `onflush` event can trigger parse complete (emulate load)
- Increased superficial load delay, to something more reliable, but it shouldn't be a problem if vtt.js is embedded in dist.
    Carey Hinoki committed Dec 7, 2015
    Configuration menu
    Copy the full SHA
    6986f4a View commit details
    Browse the repository at this point in the history

  5. Implement loading support for chapters button. 

    - Refactor chapters button and leverage `HTMLTrackElement` unified `load` event for `cue` parsing
- Manage `HTMLTrackElement` within `remoteTextTrackEls`
- Unify `addRemoteTextTrack` returns and documentation
- Rename `track` to `htmlTrackElement` for consistency within html tech
    Carey Hinoki committed Dec 7, 2015
    Configuration menu
    Copy the full SHA
    660ea2a View commit details
    Browse the repository at this point in the history

  6. Formatting.

    Carey Hinoki committed Dec 7, 2015
    Configuration menu
    Copy the full SHA
    4728389 View commit details
    Browse the repository at this point in the history

  7. Convert loadeddata to private event.

    Carey Hinoki committed Dec 7, 2015
    Configuration menu
    Copy the full SHA
    9fe17ac View commit details
    Browse the repository at this point in the history

  8. IE8 compatibility.

    Carey Hinoki committed Dec 7, 2015
    Configuration menu
    Copy the full SHA
    ceaf4af View commit details
    Browse the repository at this point in the history

  9. Formatting and documentation.

    Carey Hinoki committed Dec 7, 2015
    Configuration menu
    Copy the full SHA
    452554f View commit details
    Browse the repository at this point in the history

  10. Fix removeTrack_ to trigger event if track exists.

    Carey Hinoki committed Dec 7, 2015
    Configuration menu
    Copy the full SHA
    47e6bab View commit details
    Browse the repository at this point in the history

  11. Fix race condition (hopefully) with createTrackHelper that (When `w… 

    …indow.WebVTT` is inlined):

1. Create a `TextTrack`
2. Added `TextTrack` to `TextTrackList`
3. Loaded `TextTrack.cues` (!= null)

All before the `htmlTrackElement` was added to `this.remoteTextTrackEls()` within `addRemoteTextTrack()`.
    Carey Hinoki committed Dec 7, 2015
    Configuration menu
    Copy the full SHA
    5e5fe16 View commit details
    Browse the repository at this point in the history

  12. Addition fix for IE8 JScript_DontEnum_Bug.

    Carey Hinoki committed Dec 7, 2015
    Configuration menu
    Copy the full SHA
    1c90f74 View commit details
    Browse the repository at this point in the history

  13. Fix trackElement.srclang to be sourced from track.language.

    Carey Hinoki committed Dec 7, 2015
    Configuration menu
    Copy the full SHA
    c7a0033 View commit details
    Browse the repository at this point in the history

  14. Formatting.

    Carey Hinoki committed Dec 7, 2015
    Configuration menu
    Copy the full SHA
    71828a7 View commit details
    Browse the repository at this point in the history

  15. Adding HTMLTrackElement + HTMLTrackElementList tests.

    Carey Hinoki committed Dec 7, 2015
    Configuration menu
    Copy the full SHA
    756af99 View commit details
    Browse the repository at this point in the history

  16. Fix TextTrack existence identification for IE8 + clean up.

    Carey Hinoki committed Dec 7, 2015
    Configuration menu
    Copy the full SHA
    4ad1d2f View commit details
    Browse the repository at this point in the history

  17. Fix native text track capable browsers to initialize remote text trac… 

    …ks correctly from DOM.

- Added documentation
- Added player test
- Added api test

NOTE: important that `addTrack_` order matters in tech.js::addRemoteTextTrack.
    Carey Hinoki committed Dec 7, 2015
    Configuration menu
    Copy the full SHA
    eec4a2c View commit details
    Browse the repository at this point in the history

  18. player is made ready asynchronously

    @gkatsev
    gkatsev committed Dec 7, 2015
    Configuration menu
    Copy the full SHA
    f054347 View commit details
    Browse the repository at this point in the history

  19. Merge pull request #1 from gkatsev/chemoish-ttel 

    player is made ready asynchronously
    @chemoish
    chemoish committed Dec 7, 2015
    Configuration menu
    Copy the full SHA
    4af827d View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2015

  1. Refactor remote text track test. 

    - Add html track element test
    Carey Hinoki committed Dec 8, 2015
    Configuration menu
    Copy the full SHA
    077a4c3 View commit details
    Browse the repository at this point in the history