Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: event polyfill detection compatibility with react-native-web #7286

Merged
merged 1 commit into from
Jun 24, 2021

Conversation

awinograd
Copy link
Contributor

@awinograd awinograd commented Jun 24, 2021

Description

Fixes #7259

Specific Changes proposed

update event polyfill detection logic to be compatible with react-native-web.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

@welcome
Copy link

welcome bot commented Jun 24, 2021

💖 Thanks for opening this pull request! 💖

Things that will help get your PR across the finish line:

  • Run npm run lint -- --errors locally to catch formatting errors earlier.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@codecov
Copy link

codecov bot commented Jun 24, 2021

Codecov Report

Merging #7286 (369c0db) into main (4cecbda) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #7286   +/-   ##
=======================================
  Coverage   79.44%   79.44%           
=======================================
  Files         115      115           
  Lines        7264     7264           
  Branches     1745     1745           
=======================================
  Hits         5771     5771           
  Misses       1493     1493           
Impacted Files Coverage Δ
src/js/utils/events.js 80.40% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cecbda...369c0db. Read the comment docs.

@gkatsev gkatsev merged commit a221be1 into videojs:main Jun 24, 2021
@welcome
Copy link

welcome bot commented Jun 24, 2021

Congrats on merging your first pull request! 🎉🎉🎉

@awinograd awinograd deleted the aw-event-rnw branch July 22, 2022 22:15
edirub pushed a commit to edirub/video.js that referenced this pull request Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

react-native-web: isImmediatePropagationStopped is not a function
3 participants