Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Replace keycode dependency with event.key #8735

Merged
merged 3 commits into from
May 23, 2024

Merge branch 'main' into removekeycode

986a8bd
Select commit
Loading
Failed to load commit list.
Merged

refactor: Replace keycode dependency with event.key #8735

Merge branch 'main' into removekeycode
986a8bd
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed May 23, 2024 in 0s

33.33% of diff hit (target 83.15%)

View this Pull Request on Codecov

33.33% of diff hit (target 83.15%)

Annotations

Check warning on line 440 in src/js/control-bar/progress-control/seek-bar.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/js/control-bar/progress-control/seek-bar.js#L440 

Added line #L440 was not covered by tests

Check warning on line 444 in src/js/control-bar/progress-control/seek-bar.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/js/control-bar/progress-control/seek-bar.js#L444 

Added line #L444 was not covered by tests

Check warning on line 448 in src/js/control-bar/progress-control/seek-bar.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/js/control-bar/progress-control/seek-bar.js#L448 

Added line #L448 was not covered by tests

Check warning on line 456 in src/js/control-bar/progress-control/seek-bar.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/js/control-bar/progress-control/seek-bar.js#L456 

Added line #L456 was not covered by tests

Check warning on line 459 in src/js/control-bar/progress-control/seek-bar.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/js/control-bar/progress-control/seek-bar.js#L459 

Added line #L459 was not covered by tests

Check warning on line 466 in src/js/control-bar/progress-control/seek-bar.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/js/control-bar/progress-control/seek-bar.js#L466 

Added line #L466 was not covered by tests

Check warning on line 470 in src/js/control-bar/progress-control/seek-bar.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/js/control-bar/progress-control/seek-bar.js#L470 

Added line #L470 was not covered by tests

Check warning on line 142 in src/js/control-bar/volume-panel.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/js/control-bar/volume-panel.js#L142 

Added line #L142 was not covered by tests

Check warning on line 187 in src/js/control-bar/volume-panel.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/js/control-bar/volume-panel.js#L187 

Added line #L187 was not covered by tests

Check warning on line 300 in src/js/menu/menu-button.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/js/menu/menu-button.js#L300 

Added line #L300 was not covered by tests

Check warning on line 306 in src/js/menu/menu-button.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/js/menu/menu-button.js#L306 

Added line #L306 was not covered by tests

Check warning on line 312 in src/js/menu/menu-button.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/js/menu/menu-button.js#L312 

Added line #L312 was not covered by tests

Check warning on line 331 in src/js/menu/menu-button.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/js/menu/menu-button.js#L331 

Added line #L331 was not covered by tests

Check warning on line 359 in src/js/menu/menu-button.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/js/menu/menu-button.js#L359 

Added line #L359 was not covered by tests

Check warning on line 364 in src/js/menu/menu-button.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/js/menu/menu-button.js#L364 

Added line #L364 was not covered by tests

Check warning on line 97 in src/js/menu/menu-item.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/js/menu/menu-item.js#L97 

Added line #L97 was not covered by tests

Check warning on line 217 in src/js/menu/menu.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/js/menu/menu.js#L217 

Added line #L217 was not covered by tests

Check warning on line 223 in src/js/menu/menu.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/js/menu/menu.js#L223 

Added line #L223 was not covered by tests

Check warning on line 318 in src/js/slider/slider.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/js/slider/slider.js#L317-L318 

Added lines #L317 - L318 were not covered by tests

Check warning on line 323 in src/js/slider/slider.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/js/slider/slider.js#L322-L323 

Added lines #L322 - L323 were not covered by tests

Check warning on line 332 in src/js/slider/slider.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/js/slider/slider.js#L332 

Added line #L332 was not covered by tests

Check warning on line 338 in src/js/slider/slider.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/js/slider/slider.js#L338 

Added line #L338 was not covered by tests
View more details on Codecov