This repository has been archived by the owner on Jan 12, 2019. It is now read-only.
Duration should work when video or audio is missing #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
| strictEqual(player.hls.playlists.media().segments[0].maxAudioPts, undefined, 'max audio pts is undefined'); | ||
| }); | ||
|
|
||
| test('records PTS values for video-only segments', function() { |
If audio or video data is missing for an HLS stream, duration calculations should just use the info that is available. Fixes videojs#341.
| @@ -91,7 +107,8 @@ | |||
| // available PTS information | |||
| for (left = range.start; left < range.end; left++) { | |||
| segment = playlist.segments[left]; | |||
| if (segment.minVideoPts !== undefined) { | |||
| if (segment.minVideoPts !== undefined || | |||
There was a problem hiding this comment.
if I add .hls.playlists.media().segments = new Array(1) I will get error TypeError: Cannot read property 'minVideoPts' of undefined
There was a problem hiding this comment.
The entries of a media playlist should be segment objects-- [undefined] is not a legal value for that array. Side note: it would be better to file this sort of thing as an issue. Line comments might get overlooked.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If audio or video data is missing for an HLS stream, duration calculations should just use the info that is available. Fixes #341.