Add playback tests #894

forbesjo · 2016-11-04T21:44:12Z

This is the start to automating end to end playback tests.

gkatsev · 2016-11-04T21:49:05Z

test/playback.test.js

+import { Hls } from '../src/videojs-contrib-hls';
+
+let when = function(element, type, cb, condition) {
+  element.on(type, function func() {


why not use element.one?

I want the function to fire when the targeted event is triggered and a certain condition is met. Using one will just remove it the first time the event is fired.

For example, I use this with timeupdate and some target time.

Oh, totally missed that. I guess I was focused on less code :P

mjneil · 2016-11-08T20:48:21Z

test/playback.test.js

+  player.autoplay(true);
+
+  playFor(player, 2, function() {
+    QUnit.ok(true, 'played for three more seconds');


should this be "played for ~~three~~ two more seconds" ?

That's what I get for copy/paste

Fixed MSE and environment test helpers, restore properly Removed unused test files

mjneil · 2016-11-14T15:34:10Z

test/playback.test.js

+
+    video.width = 600;
+    video.height = 300;
+    document.querySelector('#qunit-fixture').appendChild(video);


Probably not an issue but do we want to remove the element from the DOM between tests?

qunit will automatically reset the fixture it provides https://qunitjs.com/cookbook/#keeping-tests-atomic

gesinger · 2016-11-15T17:56:46Z

test/playback.test.js

+
+QUnit.module('Playback', {
+  beforeEach() {
+    QUnit.stop();


Should we use async and done instead of stop and start?

I'll update Qunit

https://github.com/apsdehal/qunit-migrate might be useful for the other projects that are going to update qunit.

Never mind, this doesn't really work well with ES6

mjneil · 2016-11-16T18:51:13Z

LGTM

Fixed seeking behavior Updated getMediaIndexForTime to be simple and stupid Remove spurious console logs Fixed an issue with forward seeks and a different problem with backwards seeking (thanks Matt!). Fixed fast rendition change behavior. Remove limits on gap-skipper. Skip instantly without waiting. Use the proper native MediaSource duration for buffer removals. Improvements for live stream rendition changes Fixed an undefined variable bug Some more simplification and a very conservative live stream rendition change approach VOD fixes Experimental change to the way we throttle the fetcher Use GOAL_BUFFER_LENGTH again Continued massive changes to segment fetching. Cleanup and comments. Fixed a bug where we were fetching starting at mediaIndex 0 on every seek. Refactor probing code in preparation for pulling into it's own module or class Moved sync-related logic out of segment-loader and into a new sync-controller class Removed expired from the SegmentLoader Update mux.js dependency to 2.5.0 Don't error when the tsprobe returns null Fixed two issues: MAAT switching and Flash seeking Rename duration variable fix flash failing first segment load (#859) dont use tech for has played (#861) Code Coverage and Unit tests for Simple Fetcher (#862) fix has played returning false on vod (#866) Fixed preload="none" behavior and reduced the incidence of repeating initial segment requests (#878) Fixed a small bug in gap-skipper where we could seek to the same spot during a video underflow more than once Provide option to set contrib-hls first in the HTML5 tech (#889) Add playback tests (#894) remove expired time tracking and use sync points to calculate seekable (#898)

* Added playback test Fixed MSE and environment test helpers, restore properly Removed unused test files * Update to qunit 2.0

Fixed seeking behavior Updated getMediaIndexForTime to be simple and stupid Remove spurious console logs Fixed an issue with forward seeks and a different problem with backwards seeking (thanks Matt!). Fixed fast rendition change behavior. Remove limits on gap-skipper. Skip instantly without waiting. Use the proper native MediaSource duration for buffer removals. Improvements for live stream rendition changes Fixed an undefined variable bug Some more simplification and a very conservative live stream rendition change approach VOD fixes Experimental change to the way we throttle the fetcher Use GOAL_BUFFER_LENGTH again Continued massive changes to segment fetching. Cleanup and comments. Fixed a bug where we were fetching starting at mediaIndex 0 on every seek. Refactor probing code in preparation for pulling into it's own module or class Moved sync-related logic out of segment-loader and into a new sync-controller class Removed expired from the SegmentLoader Update mux.js dependency to 2.5.0 Don't error when the tsprobe returns null Fixed two issues: MAAT switching and Flash seeking Rename duration variable fix flash failing first segment load (#859) dont use tech for has played (#861) Code Coverage and Unit tests for Simple Fetcher (#862) fix has played returning false on vod (#866) Fixed preload="none" behavior and reduced the incidence of repeating initial segment requests (#878) Provide option to set contrib-hls first in the HTML5 tech (#889) This reverts commit 59ddbe1. Add playback tests (#894) Fixed MSE and environment test helpers, restore properly Removed unused test files remove expired time tracking and use sync points to calculate seekable (#898) Fixing a few tests for QUnit 2.0

gkatsev reviewed Nov 4, 2016

View reviewed changes

mjneil reviewed Nov 8, 2016

View reviewed changes

Added playback test

5b68a88

Fixed MSE and environment test helpers, restore properly Removed unused test files

forbesjo force-pushed the test/playback branch from 39e65cc to 5b68a88 Compare November 8, 2016 21:50

mjneil reviewed Nov 14, 2016

View reviewed changes

gesinger reviewed Nov 15, 2016

View reviewed changes

Update to qunit 2.0

f748213

forbesjo merged commit f2352e4 into videojs:simple-fetcher Nov 16, 2016

forbesjo deleted the test/playback branch November 16, 2016 19:14

imbcmdth pushed a commit that referenced this pull request Nov 18, 2016

Add playback tests (#894)

078041a

* Added playback test Fixed MSE and environment test helpers, restore properly Removed unused test files * Update to qunit 2.0

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add playback tests #894

Add playback tests #894

forbesjo commented Nov 4, 2016

gkatsev Nov 4, 2016

forbesjo Nov 4, 2016

gkatsev Nov 4, 2016

mjneil Nov 8, 2016 •

edited

Loading

forbesjo Nov 8, 2016

mjneil Nov 14, 2016

forbesjo Nov 14, 2016

gesinger Nov 15, 2016

gkatsev Nov 15, 2016

forbesjo Nov 15, 2016

forbesjo Nov 15, 2016 •

edited

Loading

mjneil commented Nov 16, 2016

Add playback tests #894

Add playback tests #894

Conversation

forbesjo commented Nov 4, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mjneil Nov 8, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

forbesjo Nov 15, 2016 • edited Loading

Choose a reason for hiding this comment

mjneil commented Nov 16, 2016

mjneil Nov 8, 2016 •

edited

Loading

forbesjo Nov 15, 2016 •

edited

Loading