This repository has been archived by the owner on Jan 12, 2019. It is now read-only.
Bubble progress events #978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the segment request triggers progress events (that is, XHR2 is supported), bubble those up to the tech. This makes it clearer that buffering is happening even on very slow connections.
gesinger
reviewed
Jan 25, 2017
There was a problem hiding this comment.
Everything looks good, but as a really minor note,
videojs-contrib-hls/utils/stats/stats.js
Line 96 in 96e3fc7
|
LGTM |
|
We should figure out how to use the event object in the progress listener to have better bandwidth reporting. Particularly around aborted segments. The progress event has a This definitely should go in another PR, though, but, I thought it would be good to mention here. |
|
@gkatsev yeah, that would be cool. Good to note for the future. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the segment request triggers progress events (that is, XHR2 is supported), bubble those up to the tech. This makes it clearer that buffering is happening even on very slow connections.