Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes ignoring transient fields in zio-schema based ADT codecs #435

Merged
merged 2 commits into from
Jan 13, 2024

Conversation

vigoo
Copy link
Owner

@vigoo vigoo commented Jan 13, 2024

Unfortunately the zio-schema based derived codecs for ADTs were not properly ignoring transient fields (fields marked with the transientField annotation). The original, shapeless based derivation is not affected by this.

I think any binary created by the faulty version can be read back by removing the transientField annotation from all the affected fields. If this is not the case please open an issue.

@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f24b854) 56.80% compared to head (1517df0) 56.84%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #435      +/-   ##
==========================================
+ Coverage   56.80%   56.84%   +0.04%     
==========================================
  Files          35       35              
  Lines        1750     1752       +2     
  Branches      233      233              
==========================================
+ Hits          994      996       +2     
  Misses        756      756              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vigoo vigoo merged commit b862444 into master Jan 13, 2024
6 checks passed
@vigoo vigoo deleted the transient-field-fix branch January 13, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants