Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forwardport] Fix for Magnifier in inside mode #14

Merged
merged 1 commit into from
Jun 4, 2018

Conversation

vijay-wagento
Copy link
Owner

Original Pull Request

magento#15382

Fixed Issues

  1. Magnifier doesn't work with mode set to inner magento/magento2#4977: Magnifier doesn't work with mode set to inner

Manual testing scenarios

You need to change the magnifier's configuration options in the file: app/design/frontend/Magento/luma/etc/view.xml

Set the following values ​​for these lines:

<var name="enabled">true</var>
<var name="mode">inside</var>

@vijay-wagento vijay-wagento merged commit bf30a38 into 2.3-develop Jun 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant