Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't export main package functions #69

Merged
merged 1 commit into from
Apr 21, 2019
Merged

Don't export main package functions #69

merged 1 commit into from
Apr 21, 2019

Conversation

viktomas
Copy link
Owner

Following the linting and not exporting functions from main since they don't and won't have any clients from outside the package.

  • I've read Contribution guide
  • I've tested everything that doesn't relate to tcell.Screen API

@codecov-io
Copy link

codecov-io commented Apr 21, 2019

Codecov Report

Merging #69 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #69   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           7      7           
  Lines         248    248           
=====================================
  Hits          248    248
Impacted Files Coverage Δ
interactive/printer.go 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc23d94...bf5cf65. Read the comment docs.

@viktomas viktomas merged commit f0108a9 into master Apr 21, 2019
@viktomas viktomas deleted the do-not-export branch April 21, 2019 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants