Skip to content

Commit

Permalink
Fix GLM typo on device/host pointer (rapidsai#4320)
Browse files Browse the repository at this point in the history
Closes rapidsai#4304

Authors:
  - Micka (https://github.com/lowener)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4320
  • Loading branch information
lowener authored Nov 4, 2021
1 parent 8b4bdc5 commit 60a3151
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
6 changes: 3 additions & 3 deletions cpp/include/cuml/linear_model/glm.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ namespace GLM {
* @param n_cols number of columns of the feature matrix
* @param labels device pointer to label vector of length n_rows
* @param coef device pointer to hold the solution for weights of size n_cols
* @param intercept device pointer to hold the solution for bias term of size 1
* @param intercept host pointer to hold the solution for bias term of size 1
* @param fit_intercept if true, fit intercept
* @param normalize if true, normalize data to zero mean, unit variance
* @param algo specifies which solver to use (0: SVD, 1: Eigendecomposition, 2:
Expand Down Expand Up @@ -62,10 +62,10 @@ void olsFit(const raft::handle_t& handle,
* @param n_rows number of rows of the feature matrix
* @param n_cols number of columns of the feature matrix
* @param labels device pointer to label vector of length n_rows
* @param alpha device pointer to parameters of the l2 regularizer
* @param alpha host pointer to parameters of the l2 regularizer
* @param n_alpha number of regularization parameters
* @param coef device pointer to hold the solution for weights of size n_cols
* @param intercept device pointer to hold the solution for bias term of size 1
* @param intercept host pointer to hold the solution for bias term of size 1
* @param fit_intercept if true, fit intercept
* @param normalize if true, normalize data to zero mean, unit variance
* @param algo specifies which solver to use (0: SVD, 1: Eigendecomposition)
Expand Down
2 changes: 1 addition & 1 deletion cpp/src/glm/ols.cuh
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ using namespace MLCommon;
* @param n_cols number of columns of the feature matrix
* @param labels device pointer to label vector of length n_rows
* @param coef device pointer to hold the solution for weights of size n_cols
* @param intercept device pointer to hold the solution for bias term of size 1
* @param intercept host pointer to hold the solution for bias term of size 1
* @param fit_intercept if true, fit intercept
* @param normalize if true, normalize data to zero mean, unit variance
* @param stream cuda stream
Expand Down
4 changes: 2 additions & 2 deletions cpp/src/glm/ridge.cuh
Original file line number Diff line number Diff line change
Expand Up @@ -139,10 +139,10 @@ void ridgeEig(const raft::handle_t& handle,
* @param n_rows number of rows of the feature matrix
* @param n_cols number of columns of the feature matrix
* @param labels device pointer to label vector of length n_rows
* @param alpha device pointer to parameters of the l2 regularizer
* @param alpha host pointer to parameters of the l2 regularizer
* @param n_alpha number of regularization parameters
* @param coef device pointer to hold the solution for weights of size n_cols
* @param intercept device pointer to hold the solution for bias term of size 1
* @param intercept host pointer to hold the solution for bias term of size 1
* @param fit_intercept if true, fit intercept
* @param normalize if true, normalize data to zero mean, unit variance
* @param stream cuda stream
Expand Down

0 comments on commit 60a3151

Please sign in to comment.