protocodec: make a few tweaks to allow inlining #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silvenac
approved these changes
Apr 9, 2024
protocodec.GalaxyGet is particularly hot, and trivial so it should get inlined. Make a few tweaks to allow inlining. (bringing the cost down below the magic 80 number in the go compiler) Similarly, split up protocodec.backendGetterV2.Get to allow inlining of the fast path. (Amusingly, this also allows the new `setSlow` to inline, but that wasn't the goal)
dfinkel
force-pushed
the
protocodec_inline_optimizations
branch
from
ca3c944
to
f34785d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
protocodec.GalaxyGet is particularly hot, and trivial so it should get
inlined. Make a few tweaks to allow inlining. (bringing the cost down
below the magic 80 number in the go compiler)
Similarly, split up protocodec.backendGetterV2.Get to allow inlining of
the fast path. (Amusingly, this also allows the new setSlow to inline,
but that wasn't the goal)