Fix wrong and inconsistent PHP native types in atomic #10960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkmuffme
force-pushed
the
fix-inconsistencies-in-atomic-php-types
branch
from
b3c9047
to
611e6f8
Compare
kkmuffme
force-pushed
the
fix-inconsistencies-in-atomic-php-types
branch
from
611e6f8
to
4b855a8
Compare
|
@orklah could you please merge this |
SCIF
reviewed
Jul 23, 2024
| @@ -101,7 +101,9 @@ public function toPhpString( | |||
|
|
|||
| public function canBeFullyExpressedInPhp(int $analysis_php_version_id): bool | |||
| { | |||
| return $this->type_params[0]->isMixed() && $this->type_params[1]->isMixed(); | |||
| return $analysis_php_version_id >= 7_01_00 | |||
There was a problem hiding this comment.
Does 7.1 actually should be supported?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://www.php.net/manual/en/language.types.declarations.php