Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add markerPaddingTop and markerPaddingBottom attributes. #67

Merged
merged 1 commit into from
Sep 28, 2019
Merged

Add markerPaddingTop and markerPaddingBottom attributes. #67

merged 1 commit into from
Sep 28, 2019

Conversation

tcqq
Copy link
Contributor

@tcqq tcqq commented Feb 13, 2019

Fixes #66

@vipulasri
Copy link
Owner

vipulasri commented Sep 27, 2019 •
edited
Loading

@tcqq This PR is incomplete, it only covers the library implementation. Also, corner cases are not covered example: Bottom Padding = 40dp and Top Padding = 20dp the marker either goes out of view or gets cut. But I think that responsibility lies with developer.

@vipulasri vipulasri merged commit 601a518 into vipulasri:master Sep 28, 2019
@vipulasri
Copy link
Owner

As of now merged the PR, will have to work on if anyone points any issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Request to add markerPaddingTop and markerPaddingBottom attributes
2 participants
@tcqq @vipulasri