Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to Pydantic v2 #102

Merged
merged 5 commits into from
Jul 15, 2023
Merged

Migrate to Pydantic v2 #102

merged 5 commits into from
Jul 15, 2023

Conversation

Robin5605
Copy link
Contributor

Closes #101

shenanigansd
shenanigansd requested changes Jul 14, 2023
View reviewed changes
Copy link
Member

@shenanigansd shenanigansd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move the model configs into a base case to avoid duplicating the config.

pyproject.toml Outdated Show resolved Hide resolved
src/mainframe/constants.py Show resolved Hide resolved
src/mainframe/constants.py Outdated Show resolved Hide resolved
src/mainframe/constants.py Outdated Show resolved Hide resolved
src/mainframe/constants.py Outdated Show resolved Hide resolved
src/mainframe/constants.py Outdated Show resolved Hide resolved
src/mainframe/constants.py Outdated Show resolved Hide resolved
src/mainframe/constants.py Outdated Show resolved Hide resolved
shenanigansd
shenanigansd approved these changes Jul 15, 2023
View reviewed changes
Copy link
Member

@shenanigansd shenanigansd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Robin5605 Robin5605 merged commit 0079dc6 into main Jul 15, 2023
3 checks passed
@Robin5605 Robin5605 deleted the pydantic-v2 branch July 15, 2023 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shenanigansd shenanigansd shenanigansd approved these changes

Assignees

@Robin5605 Robin5605

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate to Pydantic v2
2 participants
@Robin5605 @shenanigansd