Removes the environment variable requirement for procedural material shaders #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…shaders. Signed-off-by: Marcus Llewellyn <[email protected]>
|
Does the developer menu activate and deactivate this feature live or does it still require a restart? |
A restart is no longer required. |
|
lol nice 👍 |
9 tasks
odysseus654
pushed a commit
to odysseus654/vircadia
that referenced
this pull request
Sep 5, 2021
[v8] one more step forward
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, it is no longer necessary to create the HIFI_ENABLE_MATERIAL_PROCEDURAL_SHADERS environment variable. Users only need to have the Developer menu active, and then check the menu option Developer->Render->Enable Procedural Materials
Tested on:
Windows 10 Pro 1909 build 18363.476
CMake 3.16.0
Microsoft Visual Studio Community 2019 Version 16.4.0