Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add patch for building Qt 5.15 on gcc11 #1218

Merged
merged 1 commit into from
May 20, 2021

Conversation

daleglass
Copy link
Contributor

gcc11 is requires #include <limits> in places previous versions didn't.

This makes Qt 5.15.2 build on Fedora 34, and this should also extend to other recent Linux distros.

@daleglass daleglass added linux This is related to Linux. needs CR (code review) needs testing (QA) The PR is ready for testing labels May 18, 2021
gcc11 is requires #include <limits> in places previous versions didn't.
Copy link
Contributor

@JulianGro JulianGro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is part of the c++ standard library. It's inclusion shouldn't be able to break anything, and if the compiler doesn't complain it should be safe to use (even if you don't know what exactly it is used for like I do).

@digisomni digisomni added CR Approved At least one code reviewer has approved the PR. and removed needs CR (code review) needs testing (QA) The PR is ready for testing labels May 20, 2021
@digisomni digisomni added this to the 2021.1.2 Eos Release milestone May 20, 2021
@digisomni digisomni merged commit f1b4c8e into vircadia:master May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix CR Approved At least one code reviewer has approved the PR. linux This is related to Linux.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants