Housekeeping: Update use of "auto" with plugin lists. #1340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digisomni
added
allow-build-upload
|
The following links are available: build (ubuntu-18.04, full)
build (macOS-latest, full) build (windows-latest, full) |
daleglass
suggested changes
Sep 19, 2021
| @@ -3466,7 +3466,7 @@ void Application::initializeUi() { | |||
| #if !defined(DISABLE_QML) | |||
| // Now that the menu is instantiated, ensure the display plugin menu is properly updated | |||
| { | |||
| auto displayPlugins = PluginManager::getInstance()->getDisplayPlugins(); | |||
| DisplayPluginList displayPlugins = PluginManager::getInstance()->getDisplayPlugins(); | |||
There was a problem hiding this comment.
Why this one? Is there a const missing here?
There was a problem hiding this comment.
This cannot be a constant reference as the code below this line sorts the plugin list, so it needs to start with a copy of the list.
I'm not sure why I changed it from "auto", it may have slipped through from a previous revision of this PR.
HifiExperiments
approved these changes
Sep 19, 2021
digisomni
added
CR Approved
daleglass
approved these changes
Sep 19, 2021
digisomni
changed the title
digisomni
changed the title
digisomni
changed the title
|
The following links are available: build (macOS-10.15, full) build (ubuntu-18.04, full)
build (windows-latest, full) build (self-hosted_debian-11_aarch64, full)
|
digisomni
added
rebuild
digisomni
approved these changes
Dec 9, 2021
digisomni
added
QA Approved
|
The following links are available:
build (macOS-10.15, client) build (windows-latest, full) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The returned plugin lists are all coming back as "const&" and in most cases are assigned to "auto" (which strips out qualifiers).
This adds in as many "const auto&" ref qualifiers as I could for plugin references so as to reduce unnecessary copies.
(This came out of a tooltip while poking at the networking code)
Testing focus: