Fix deprecated usage of multiple keys in QHash and QMap. #1468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digisomni
added
housekeeping
digisomni
changed the title
|
The following links are available: build (macOS-10.15, full) build (ubuntu-18.04, full)
build (windows-latest, full) build (self-hosted_debian-11_aarch64, full)
|
HifiExperiments
approved these changes
Nov 23, 2021
|
@HifiExperiments Yeah, the space stuff isn't ideal but that's easy enough to fix if anything conflicts. Also makes things a bit less annoying, as it avoids the need to mess with the whitespace by hand. I think maybe we could just do a giant whitespace tidying commit some day and then install a rule that from now on, it must be perfect. |
HifiExperiments
added
CR Approved
…d QMap This replaces those uses with QMultiHash and QMultiMap
daleglass
force-pushed
the
qt5-fix-multimap
branch
from
33ac65c
to
d77c8bb
Compare
uniqueKeys() is deprecated, and _resources shouldn't contain duplicated keys.
|
The following links are available: build (macOS-10.15, client) build (ubuntu-18.04, full)
build (windows-latest, full) build (self-hosted_debian-11_aarch64, full)
|
digisomni
approved these changes
Dec 3, 2021
digisomni
added
QA Approved
digisomni
added a commit
that referenced
this pull request
Jan 15, 2022
Fix MultiHash issues added in PR #1468.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces those uses with QMultiHash and QMultiMap. This removes a fair amount of warnings. Only 157 to go.