Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated WebRTC library for Linux to version 5387. #1714

Merged
merged 35 commits into from
Nov 22, 2022
Merged

Updated WebRTC library for Linux to version 5387. #1714

merged 35 commits into from
Nov 22, 2022

Conversation

namark
Copy link
Contributor

@namark namark commented Nov 4, 2022 •
edited
Loading

@namark
Updated Linux WebRTC library to version 5387,
4704278 
There were some API breaking changes so the usage has been updated to
support both old and new versions.
@namark
Fixed an undefined reference in octree library.
fb97f26
@namark
Fixed directory structure of the WebRTC package for Linux.
bcbeaff
@namark
GHA build config for Ubuntu 20.04.
91efd79
@namark
Fixed dependency package version for Ubuntu 20.04 GHA build.
1cf52bc
@namark
Fixed Ubuntu 20.04 GHA build malformed apt install command.
3164ade
@namark
Added a server deb package steps to the Ubuntu 20.04 GHA build.
eb76dbe
@namark
Fixing server deb package build in GHA setup.
c198c64
@namark
Building oven and ICE server for Ubuntu 20.04 deb package in GHA.
b26cdec
@namark
Enabled tools in GHA full builds for Ubuntu,
a23c7cd 
to build oven for the deb package.
@namark
Skipping Build Installer step on Ubuntu GHA builds.
c4a7b82
@namark
Fixed PR build GHA installer conditional.
654c21f
@namark
Fixed server deb package step included in GHA android build.
152c434
@namark
Skip upload full build step in GHA ubuntu builds.
23449cc
@namark
Fixed a syntax error in GHA PR build script.
93bb05e
@namark
Added capabilities object to domain server -> metaverse heartbeat req…
e5d21d7 
…uests.

Including information on WebRTC configuration, exporters and audio codec
preference.
@namark
WebRTC build instruction for Ubuntu 20.04
0c00420
@namark
Minor fixes in WebRTC build instructions for Ubuntu.
9ed7fc7
@namark
A minor formatting fix in WebRTC build instructions for Ubuntu.
9b12f92
@namark namark marked this pull request as ready for review November 8, 2022 23:01
@digisomni digisomni added this to the 2022.1.2 Selene Release milestone Nov 10, 2022
ctrlaltdavid
ctrlaltdavid requested changes Nov 13, 2022
View reviewed changes
.github/workflows/pr_build.yml Outdated Show resolved Hide resolved
libraries/networking/src/webrtc/WebRTCDataChannels.cpp Outdated Show resolved Hide resolved
libraries/networking/src/webrtc/WebRTCDataChannels.h Outdated Show resolved Hide resolved
@ctrlaltdavid
Copy link
Collaborator

QA: Needs building and testing on Windows as well as Linux.

@namark
Copy link
Contributor Author

namark commented Nov 14, 2022 •
edited
Loading

Windows installer should be available as an artifact, as well as the ubuntu 20.04 server package (which is currently also deployed).

@ctrlaltdavid ctrlaltdavid added CR Approved At least one code reviewer has approved the PR. and removed needs CR (code review) labels Nov 15, 2022
@namark
Copy link
Contributor Author

namark commented Nov 20, 2022

Accidentally merged in the #1716, but shouldn't be a problem since both PRs are ready.

@digisomni digisomni added the QA Approved The PR has been tested successfully. label Nov 22, 2022
@digisomni digisomni merged commit 236e06d into vircadia:master Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctrlaltdavid ctrlaltdavid ctrlaltdavid approved these changes

Assignees
No one assigned
Labels
CR Approved At least one code reviewer has approved the PR. enhancement New feature or request QA Approved The PR has been tested successfully.
Projects
None yet
Milestone
2022.1.2 Selene Release
Development

Successfully merging this pull request may close these issues.
3 participants
@namark @ctrlaltdavid @digisomni