Domain UI overhaul, part 1. #1728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were some API breaking changes so the usage has been updated to support both old and new versions.
to build oven for the deb package.
Co-authored-by: David Rowe <[email protected]> Signed-off-by: namark <[email protected]>
Bumps [loader-utils](https://github.com/webpack/loader-utils) from 1.4.1 to 1.4.2. - [Release notes](https://github.com/webpack/loader-utils/releases) - [Changelog](https://github.com/webpack/loader-utils/blob/v1.4.2/CHANGELOG.md) - [Commits](webpack/loader-utils@v1.4.1...v1.4.2) --- updated-dependencies: - dependency-name: loader-utils dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
…namark/vircadia into linux-webrtc-update-5387
domain-server/resources/web/web-new/src/components/settings/AudioThreading.vue
Outdated
Show resolved
Hide resolved
domain-server/resources/web/web-new/src/modules/domain/interfaces/settings.ts
Show resolved
Hide resolved
domain-server/resources/web/web-new/src/pages/Settings/Networking.vue
Outdated
Show resolved
Hide resolved
domain-server/resources/web/web-new/src/pages/Settings/Entities.vue
Outdated
Show resolved
Hide resolved
domain-server/resources/web/web-new/src/pages/Settings/Avatars.vue
Outdated
Show resolved
Hide resolved
domain-server/resources/web/web-new/src/pages/Settings/Audio.vue
Outdated
Show resolved
Hide resolved
domain-server/resources/web/web-new/src/modules/domain/settings.ts
Outdated
Show resolved
Hide resolved
domain-server/resources/web/web-new/src/modules/domain/settings.ts
Outdated
Show resolved
Hide resolved
domain-server/resources/web/web-new/src/modules/domain/settings.ts
Outdated
Show resolved
Hide resolved
Gigabyte5671
requested changes
Mar 28, 2023
There was a problem hiding this comment.
I'll address the few changes necessary.
Otherwise, it's a pretty clean PR. @luorixo, you're a legend! :)
|
We have this separate UI for the ACME client under domain-server/resources/web/ssl-acme-client that we'll also need a version of in the new UI. It uses the usual settings.json API in conjunction with a few ACME client specific APIs. There is a basic description of it here from the user perspective |
Gigabyte5671
approved these changes
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
networkingpage UI (and small parts of the functionality)