Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avatar auto scale: match avatar eye height to user eye height. #942

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Commits on Dec 28, 2020

  1. Avatar auto scale: match avatar eye height to user eye height.

    This adds an 'Auto' button to the avatar scale slider.  The Auto button scales the avatar so that its eye height matches the user's real-world eye height (based on the 'User real world height' setting).  In this way, the world is displayed at exactly 100% scale to the user in VR.
    
    The '1x' button now sets the avatar scale to 1.0 even if the current scale is at the same 'notch' as 1.0 on the scale slider (previously it had no effect in that situation).
    
    Test done:
    - In VR, kneel to position your head as if you were 1m tall.
    - Set 'User real-world height' to 1m (in Settings > Controls).
    - Open the Avatar app and click on the sliders icon at the top-right.
    - Click the '1x' button and observe that the world is miniaturised.
    - Click the 'Auto' button and observe that the world is displayed at actual size.
    Phil-Palmer committed Dec 28, 2020
    Configuration menu
    Copy the full SHA
    a391489 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    597cc07 View commit details
    Browse the repository at this point in the history

Commits on Dec 29, 2020

  1. Apply suggestions from code review

    Improve comments and fix bracing style.
    
    Co-authored-by: David Rowe <[email protected]>
    Phil-Palmer and ctrlaltdavid authored Dec 29, 2020
    Configuration menu
    Copy the full SHA
    63c3121 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e89e80d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5acb41a View commit details
    Browse the repository at this point in the history