Tournament lobby + dashboard #904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for code re-use with forthcoming tournament and education lobbies
need to implement TournamentLobby view which will basically be a LobbyRoom component adapted to remove controls and to interface with the tournament lobby room on the server
add freeplay/tourn lobby toggles and offsets to admin settings interface
- start to add tournament dashboard (pre-lobby) step - refactor survey/tournament routes
sgfost
force-pushed
the
tournament-mode
branch
from
dbae844
to
17168eb
Compare
- include description in tournament cli creation - add new tournament + initial scheduled launch dates - refs virtualcommons/planning#50
- isolate invite specific data from general tournament status which is now used to initialize the client store when tournament mode is on - check invites in onAuth in tournament lobby - included migration for renaming 'openbeta' tournament to 'freeplay' along with renaming other instances Co-authored-by: Allen Lee <[email protected]>
- TournamentLobbyRoom now drains all connected clients when it allocates random groups of connected participants - add pending group management + client cleanup logic to TournamentLobbyRoomState - use lodash Fisher-Yates shuffle instead of hand-rolled random sort (which is cautioned against due to lack of random-ness, see https://stackoverflow.com/a/18650169/93370 for more details) - replace maxClients with maxConnections throttling support in tournament lobby - FreePlayLobby currently does not max out, but we may want to revisit that and include a check against total number of active participants and maxConnections in onAuth or canClientJoin - consider moving getFilledUsernames and other autobot filling routines into FreePlay to prevent tournament lobby from creating rooms with bots
- reworked schedule/countdown components TODO: add links and announcement banner to homepage ref virtualcommons/planning#49
|
thanks for the matchmaking changes @alee. Dashboard is up and running, I'll put together an announcement banner + linkage tomorrow |
ideally this would use text retrieved from a tournament/round on the backend, a full description and round announcement are way too wordy for a banner but we should communicate the main points. Consider a shortDescription field in the Tournament
- changed wording of nov 2023 tournament desc/announcement Co-authored-by: Allen Lee <[email protected]>
alee
approved these changes
Oct 28, 2023
| @@ -1,15 +1,19 @@ | |||
| <template> | |||
| <div class="countdown"> | |||
| <div class="countdown-block"> | |||
| <div class="countdown-digit">{{ format(hours) }}</div> | |||
| <div class="countdown-digit" :style="`font-size: ${size}rem`">{{ format(days) }}</div> | |||
There was a problem hiding this comment.
might consider putting this into a digitStyle getter that returns the string font-size: ${size}rem for now but could also add other custom styles?
Not blocking this merge, just for the future
| @@ -55,7 +60,7 @@ export class AjaxRequest { | |||
| ({ data, status }) => { | |||
| if (status === 200) { | |||
| this.store.commit("SET_USER", data.user); | |||
| if (data.user.isVerified) this.router.push({ name: LOBBY_PAGE }); | |||
| if (data.user.isVerified) this.router.push({ name: FREE_PLAY_LOBBY_PAGE }); | |||
There was a problem hiding this comment.
Should we add another check to see if we should funnel them to the tournament dashboard instead?
There was a problem hiding this comment.
Oh yeah I suppose that would be one way to fix it, though may be confusing to route to one or the other when both are active. I think routing to home is fine until there's a way to pass a next param to the login routes
- add getters for tstore access, feeding the consistency hobgoblin - include timezone in toLocaleTimeString - move logo style into portOfMarsLogoProps - remove dead code, unused props and attributes, etc.
- guard against empty leaderboard errors - add event description back to calendar-event - build a single event object and reuse for multiple links - improve :key usage though maybe we don't even need them anymore, see https://v3-migration.vuejs.org/breaking-changes/key-attribute.html - 404 errors in the ajax plugin now redirect to HOME_PAGE, not FREE_PLAY_LOBBY_PAGE - remove dead code + yarn style:fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add tournament lobby, dashboard
add banner to the landing page
add tournament participation links to the navbar, landing page, and footer