Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing with testify not compatible with Go 1.12 #596

Closed
taktv6 opened this issue Nov 21, 2020 · 0 comments
Closed

Testing with testify not compatible with Go 1.12 #596

taktv6 opened this issue Nov 21, 2020 · 0 comments

Comments

@taktv6
Copy link

taktv6 commented Nov 21, 2020

Hi there,

in PR #572 I was asked to add some tests to my code.
I did that and I needed a way to compare structures.
github.com/stretchr/testify is IMHO a great and easy way of doing so.

Problem is: It's not compatible with Go 1.12 and older.
Unfortunately the netlink projects CI tries to build for 1.12, 1.13 and 1.14.

Please allow me 2 questions:

  1. What's the projects strategy regarding support for older Go versions? (If it would be "last 3 versions" then 1.12 should be dropped and 1.15 should be added.)
  2. Is it okay to use testify here or is there an alternative I should use?

Kind Regards
takt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant