SocketDiagTCPInfo: Add support for BBR information

[taktv6]

No description provided.

[taktv6]

Any chance I could get some feedback?

[vishvananda]

This is looking good to me. Any way to add a test for the functionality? Also, when you are ready to go, please squash your changes down into a single commit.

[taktv6]

Thank you for your feedback. I've refactored the SocketDiagTCPInfo function and added some tests.
Unfortunately testify doesn't support Go 1.12 anymore. What would you like me to use as an alternative?

[leoluk]

This would be super useful to have - any news on this?

[taktv6]

@vishvananda feedback pls?

[aboch]

LGTM

Please squash these changes in one commit ("Squash and merge" is not enabled here).

[taktv6]

Okay. But any idea about the testify issue?
See #596

[aboch]

But any idea about the testify issue?

Yes, I'd suggest to remove the testify import from these changes. Check the struct equality in the test code.

I would stick to the builtin go testing package, because of the simplicity of the functions that needs to be tested here and for keeping this small library code base lean.

[taktv6]

Okay. I'll sort that out tomorrow. Thanks!

[aboch]

LGTM