Consistent error handling across *SubscribeAt functions #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: eriknordmark <[email protected]>
milan-zededa
added a commit
to milan-zededa/eve
that referenced
this pull request
Oct 13, 2021
All changes in our fork of vishvananda/netlink have been accepted and merged into the upstream: - vishvananda/netlink#654 - vishvananda/netlink#659 Signed-off-by: Milan Lenco <[email protected]>
milan-zededa
added a commit
to milan-zededa/eve
that referenced
this pull request
Oct 13, 2021
All changes in our fork of vishvananda/netlink have been accepted and merged into the upstream: - vishvananda/netlink#654 - vishvananda/netlink#659 Signed-off-by: Milan Lenco <[email protected]>
eriknordmark
pushed a commit
to lf-edge/eve
that referenced
this pull request
Oct 15, 2021
All changes in our fork of vishvananda/netlink have been accepted and merged into the upstream: - vishvananda/netlink#654 - vishvananda/netlink#659 Signed-off-by: Milan Lenco <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening PR with a commit from my colleague @eriknordmark which unifies error handling between
addrSubscribeAt,linkSubscribeAtandrouteSubscribeAt.The behavior is that while error from
Receive()closes the subscription, a notification with unexpected data is just skipped trough with error message sent over through the provided callback. (already done this way foraddrSubscribeAt)Signed-off-by: eriknordmark [email protected]