Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for bareudp link type #657

Merged
merged 1 commit into from
Sep 17, 2021
Merged

Conversation

bersoare
Copy link
Contributor

@bersoare bersoare commented Jun 3, 2021

this PR adds support for bareudp link attributes.

2 links with similar attributes - one created using this code, another one using iproute2:

13: bareudp1: <POINTOPOINT,MULTICAST,NOARP> mtu 1500 qdisc noop state DOWN mode DEFAULT group default qlen 1000
    link/none  promiscuity 0 minmtu 68 maxmtu 65527
    bareudp dstport 6636 ethertype mpls_uc srcportmin 12345 multiproto addrgenmode eui64 numtxqueues 1 numrxqueues 1 gso_max_size 65536 gso_max_segs 65535
14: foo99: <POINTOPOINT,MULTICAST,NOARP> mtu 1500 qdisc noop state DOWN mode DEFAULT group default
    link/none  promiscuity 0 minmtu 68 maxmtu 65527
    bareudp dstport 6635 ethertype mpls_uc srcportmin 12345 multiproto addrgenmode eui64 numtxqueues 1 numrxqueues 1 gso_max_size 65536 gso_max_segs 65535

link.go Outdated Show resolved Hide resolved
@aboch
Copy link
Collaborator

aboch commented Sep 15, 2021

LGTM

But I we need to wait for @vishvananda to see if he can revive Travis CI integration

@aboch
Copy link
Collaborator

aboch commented Sep 16, 2021

Please rebase and force-push so that CI (now fixed) is triggered

@aboch
Copy link
Collaborator

aboch commented Sep 17, 2021

LGTM

@aboch aboch merged commit 7992ad9 into vishvananda:master Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants