Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly indicate no config-site or fatal error if not found #19922

Open
wants to merge 2 commits into
base: 3.4RC
Choose a base branch
from

Conversation

markcmiller86
Copy link
Member

@markcmiller86 markcmiller86 commented Oct 19, 2024

Description

This adjust behavior during CMake. CMake will fatally error if -DVISIT_CONFIG_SITE=NONE is NOT specified and it cannot find a config-site file.

The error will look like...

CMake Error at CMakeLists.txt:687 (message):
  The config-site file,
  /Users/miller86/visit/visit/34rc/src/config-site/scratlantis.cmake, does
  not exist.  Pass -DVISIT_CONFIG_SITE=NONE if no config-site file is needed.

In other words, if you want to configure with -C <someCacheFile> or by specifying a slew of -DVISIT_CMAKE_VARIABLE=VALUE options, you can but you MUST ALSO INDICATE you do not want a config site file with -DVISIT_CONFIG_SITE=NONE (or OFF or NO case does not matter).

This also makes sure we never wind up accidentally caching a value for VISIT_CONFIG_SITE and VISIT_CONFIG_SITE_FILE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant