Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular compatibility #115

Closed
dcop opened this issue Aug 24, 2018 · 3 comments
Closed

Angular compatibility #115

dcop opened this issue Aug 24, 2018 · 3 comments
Assignees
Labels

Comments

@dcop
Copy link

dcop commented Aug 24, 2018

I'm trying to import the module into an angular 4 application, but I get the following error:

ERROR in Error: Metadata version mismatch for module ngx-vis.d.ts, found version 4, expected 3

Reading here and there I see that this is something related to the supported angular version :

  • angular 4 has metadata v3
  • angular 5 has metadata v4

Now, checking ngx-vis/ngx-vis.metadata.json I see that module version is indeed 4.
Is this something intended?

Thanks

@hypery2k
Copy link
Collaborator

no not actually. Any PR would be welcome

@hypery2k hypery2k added the bug label Aug 24, 2018
@dcop
Copy link
Author

dcop commented Aug 27, 2018

I'm kinda new to this stuff, so I googled and found (angular/angular#19607)

I went ahead and downgraded to Angular 4 in package.json in my local build and module version is now 3. I don't know if this is the right way to do it or this thing will break something for newest Angular releases and if it's worth doing it.

What do you think?

@hypery2k
Copy link
Collaborator

sorry to say, but will only support Angular 5+ in the next version

@hypery2k hypery2k self-assigned this Oct 20, 2018
hypery2k added a commit that referenced this issue Oct 20, 2018
BREAKING CHANGE: The package will only support Angular 5+ because with this version metadata v4 was introduced, see #115
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants