-
-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Shapes4FREE icons #116
Comments
@ajorg-aws Thanks! |
Related #31 |
We can use instead of https://github.com/visjs/vis-network/blob/master/docs/img/external-link-icons/external-link-icon.png a "shortcut" icon from https://iconsvg.xyz/ |
|
@mojoaxel maybe we just remove them? I didn't find any reference in vis-network files. |
Hmm, I checked all of the projects and it doesn't seem to be used at all. We can probably remove it from all of them without any replacement. @r3code do you plan to open PRs? Occurrences:
|
If you want to you can. My motivation for opening these additional issues and not doing it myself was that this is a straightforward thing for first time contributors who don't have deep insight into the project but still want to contribute. You know something easy that anybody can do and then maybe work their way up to more complex contributions. |
🎉 This issue has been resolved in version 6.1.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
The documentation uses external link icons from Shapes4FREE. The Shapes4FREE License is not an open source license (does not allow redistribution). There are comparable icons available from open source icon libraries. For example, Feather has a nice external link icon and an MIT License. Font Awesome also has some external link icons and a CC-BY-4.0 license for those, and there are likely other open source projects with similar icons. Alternatively, Unicode has the ↪ character, which is often used to denote external links, though it's not as familiar.
Would you consider replacing the Shapes4FREE icons with open source icons?
The text was updated successfully, but these errors were encountered: