Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): remove unused Shapes4FREE icons #145

Merged
merged 1 commit into from
Oct 1, 2019
Merged

chore(docs): remove unused Shapes4FREE icons #145

merged 1 commit into from
Oct 1, 2019

Conversation

omsi6
Copy link
Contributor

@omsi6 omsi6 commented Oct 1, 2019

This is a pretty simple PR which fixes #116.

I do have a question though, the template for submitting a PR has this line:
* [ ] All pull requests must be to the [develop branch](https://github.com/almende/vis/tree/develop). Pull requests to the `master` branch will be closed!
But this would seem counter to what I've seen from looking at past PRs, as they're all made directly to master. And not to mention, the repo it links to is archived and redirects to here, where there is no development branch. Am I missing something here? Or is this just an oversight from having a legacy PR template?

Copy link
Member

@Thomaash Thomaash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @omsi6,

thank you very much for your contribution. Regarding the develop branch confusion it's outdated PR template. We'll have to change it. Just ignore it for now. You did everything right.

@Thomaash Thomaash changed the title remove unused Shapes4FREE icons chore: remove unused Shapes4FREE icons Oct 1, 2019
@Thomaash Thomaash changed the title chore: remove unused Shapes4FREE icons chore(docs): remove unused Shapes4FREE icons Oct 1, 2019
@Thomaash Thomaash merged commit e3e701d into visjs:master Oct 1, 2019
@vis-bot
Copy link
Collaborator

vis-bot commented Oct 24, 2019

🎉 This PR is included in version 6.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Shapes4FREE icons
3 participants