New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test warning #951

Merged

vitalik merged 1 commit into vitalik:master from jairhenrique:test-warning

Nov 22, 2023

Contributor

jairhenrique commented Nov 22, 2023

pytest assumes router function with test prefix as a test.. but it's not.

tests/test_request.py::test_schema
  /envs/django-ninja/lib/python3.12/site-packages/_pytest/python.py:198: PytestReturnNotNoneWarning: Expected None, but tests/test_request.py::test_schema returned 'ok', which will be an error in a future version of pytest.  Did you mean to use `assert` instead of `return`?
    warnings.warn(


          Fix test warning

cd857bc

vitalik merged commit 7b9fe7e into vitalik:master

39 of 40 checks passed

jairhenrique deleted the test-warning branch

November 22, 2023 12:48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet