fix(optimizer): # symbol in deps id stripped by browser (#12415)

Co-authored-by: patak <[email protected]>
vitejs · Mar 15, 2023 · e23f690 · e23f690
1 parent 2b37cde
commit e23f690
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/packages/vite/src/node/utils.ts b/packages/vite/src/node/utils.ts
@@ -79,6 +79,7 @@ export const flattenId = (id: string): string =>
     .replace(/[/:]/g, '_')
     .replace(/\./g, '__')
     .replace(/(\s*>\s*)/g, '___')
+    .replace(/#/g, '____')
 
 export const normalizeId = (id: string): string =>
   id.replace(/(\s*>\s*)/g, ' > ')

diff --git a/playground/resolve/__tests__/resolve.spec.ts b/playground/resolve/__tests__/resolve.spec.ts
@@ -155,7 +155,7 @@ test('resolve.conditions', async () => {
 
 test('resolve package that contains # in path', async () => {
   expect(await page.textContent('.path-contains-sharp-symbol')).toMatch(
-    '[success]',
+    '[success] true',
   )
 })
 

diff --git a/playground/resolve/index.html b/playground/resolve/index.html
@@ -340,7 +340,9 @@ <h2>resolve package that contains # in path</h2>
   text('.inline-pkg', inlineMsg)
 
   import es5Ext from 'es5-ext'
-  text('.path-contains-sharp-symbol', '[success]')
+  import contains from 'es5-ext/string/#/contains'
+
+  text('.path-contains-sharp-symbol', `[success] ${contains.call('#', '#')}`)
 </script>
 
 <style>