Failed transformation due to bad scope analysis for catch blocks

[gtm-nayan]

Describe the bug

Ben has described the issue here, #10289, not sure if it's a regression or a case was missed then, but I ran into it again today when the shadowing variable name was inside a catch block

Reproduction

https://github.com/gtm-nayan/vite-import-transformation-bug

Steps to reproduce

Clone the repo

pnpm i && pnpm dev

Failed transformation may be easier to see if you pause on the debugger

System Info

System:
    OS: Linux 5.15 Ubuntu 22.04.1 LTS 22.04.1 LTS (Jammy Jellyfish)
    CPU: (4) x64 AMD Ryzen 7 5800H with Radeon Graphics
    Memory: 2.98 GB / 6.70 GB
    Container: Yes
    Shell: 5.1.16 - /bin/bash
  Binaries:
    Node: 18.12.1 - ~/.local/share/pnpm/node
    Yarn: 1.22.19 - /mnt/wslg/runtime-dir/fnm_multishells/9196_1674575406312/bin/yarn
    npm: 9.2.0 - ~/.local/share/pnpm/npm
  npmPackages:
    vite: ^4.0.0 => 4.0.4

Used Package Manager

pnpm

Logs

No response

Validations

• Follow our Code of Conduct
• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
• The provided reproduction is a minimal reproducible example of the bug.

[gtm-nayan]

Turns out it's not related to catch, the bug exists for normal blocks as well. Updated the repo with a simpler case.