Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vite dev server crashes if error is introduced in vite.config.js #12375

Closed
7 tasks done
Rich-Harris opened this issue Mar 11, 2023 · 0 comments · Fixed by #12379
Closed
7 tasks done

Vite dev server crashes if error is introduced in vite.config.js #12375

Rich-Harris opened this issue Mar 11, 2023 · 0 comments · Fixed by #12379
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)

Comments

@Rich-Harris
Copy link
Contributor

Describe the bug

If you run vite dev then introduce a syntax error in vite.config.js, the dev server tries and fails to restart, and the process crashes.

Ideally the process would stay alive, and gracefully recover once the error is fixed. Even better would be if the server survived, if only to report the error, though that's probably somewhat trickier.

Reproduction

https://github.com/Rich-Harris/vite-dev-server-crashes

Steps to reproduce

Instructions in the repro README

System Info

System:
    OS: macOS 13.2.1
    CPU: (10) arm64 Apple M1 Pro
    Memory: 144.45 MB / 32.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 18.15.0 - ~/Library/pnpm/node
    npm: 9.5.0 - ~/Library/pnpm/npm
  Browsers:
    Chrome: 111.0.5563.64
    Firefox: 110.0.1
    Safari: 16.3
  npmPackages:
    vite: ^4.1.4 => 4.1.4

Used Package Manager

pnpm

Logs

No response

Validations

@bluwy bluwy added p3-minor-bug An edge case that only affects very specific usage (priority) and removed pending triage labels Mar 11, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants