Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project Name #2360

Closed
3 tasks done
king-11 opened this issue Mar 3, 2021 · 4 comments
Closed
3 tasks done

Project Name #2360

king-11 opened this issue Mar 3, 2021 · 4 comments

Comments

@king-11
Copy link

king-11 commented Mar 3, 2021

Describe the bug

Currently, the Vite project name accepts space-separated names for a project which isn't supported in the package.json

Reproduction

yarn create @vitejs/app
yarn
  • enter project name as vite app or any set of words with space.

System Info

  • vite version: 2.0.5
  • Operating System: Manjaro
  • Node version: v14.15.2
  • Package manager (npm/yarn/pnpm) and version: yarn

Logs (Optional if provided reproduction)

  1. Run vite or vite build with the --debug flag.
  2. Provide the error log here.
@sunkehappy
Copy link

You'd better do NOT add special characters in project name. This is not a good habit. A lot of tools don't support special characters in project name.

@king-11
Copy link
Author

king-11 commented Mar 5, 2021

@sunkehappy 🤔yeah for that purpose can we like include validation during input from user that will be not be a big overhead I believe

@sunkehappy
Copy link

@king-11 Yeah good idea. I will create a pull request to prevent user from input special characters in project name.

sunkehappy added a commit to sunkehappy/vite that referenced this issue Mar 5, 2021
sunkehappy added a commit to sunkehappy/vite that referenced this issue Mar 6, 2021
sunkehappy added a commit to sunkehappy/vite that referenced this issue Mar 7, 2021
@king-11
Copy link
Author

king-11 commented Mar 15, 2021

@yyx990803 thanks for addressing the issue

@github-actions github-actions bot locked and limited conversation to collaborators Jul 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants