Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plugin-vue] Can't use custom compiler #6587

Closed
7 tasks done
surmon-china opened this issue Jan 21, 2022 · 2 comments · Fixed by #6588
Closed
7 tasks done

[plugin-vue] Can't use custom compiler #6587

surmon-china opened this issue Jan 21, 2022 · 2 comments · Fixed by #6588

Comments

@surmon-china
Copy link
Contributor

Describe the bug

The compiler default value null results rawOptions.compiler never used.

let options: ResolvedOptions = {
isProduction: process.env.NODE_ENV === 'production',
...rawOptions,
include,
exclude,
customElement,
reactivityTransform,
root: process.cwd(),
sourceMap: true,
compiler: null as any // to be set in buildStart

Reproduction

b289b2d#diff-2b066c2eb45a74f1191f8796c6c76a93a7bc81417b11b8852e965aec86be2cc4

System Info

System:
    OS: macOS 12.1
    CPU: (8) x64 Apple M1
    Memory: 36.40 MB / 16.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 14.18.0 - /usr/local/bin/node
    Yarn: 1.22.4 - /usr/local/bin/yarn
    npm: 6.14.15 - /usr/local/bin/npm
  Browsers:
    Chrome: 97.0.4692.99
    Firefox Developer Edition: 97.0
    Safari: 15.2
  npmPackages:
    @vitejs/plugin-vue: ^2.0.1 => 2.0.1
    vite: ^2.7.13 => 2.7.13

Used Package Manager

yarn

Logs

"Failed to resolve vue/compiler-sfc.\n@vitejs/plugin-vue requires vue (>=3.2.13) or @vue/compiler-sfc to be present in the dependency tree."

Validations

@surmon-china
Copy link
Contributor Author

#6232
#5326

@haoqunjiang
Copy link
Member

haoqunjiang commented Jan 25, 2022

While this does look like a bug, the commit that introduced this issue is ce8b0fe#diff-2b066c2eb45a74f1191f8796c6c76a93a7bc81417b11b8852e965aec86be2cc4R109 not the one in the original post.

patak-dev pushed a commit that referenced this issue Jan 26, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Feb 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants