Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add module types #10299

Merged
merged 4 commits into from
Oct 2, 2022
Merged

Conversation

sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Sep 30, 2022

Description

This PR adds *?worker&url,*?sharedworker&inline,*?sharedworker&url,*.sss,*.module.sss type to client.d.ts.

Also I reordered a bit to align with src/node/constants.ts.

refs #7914, #6705

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red changed the title fix: add ?worker&url type fix: add module types Oct 1, 2022
@patak-dev patak-dev merged commit 0b89dd2 into vitejs:main Oct 2, 2022
@sapphi-red sapphi-red deleted the fix/add-worker-url-type branch October 3, 2022 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2-edge-case Bug, but has workaround or limited in scope (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants