Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hmr): handle virtual module update #10324

Merged
merged 1 commit into from
Oct 3, 2022
Merged

fix(hmr): handle virtual module update #10324

merged 1 commit into from
Oct 3, 2022

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Oct 3, 2022

Description

Alternative to #10313
Should also fix #6871 but I'm not sure how to test it

This PR ensures HMR urls are properly wrapped before sending to the HMR client.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added feat: hmr p3-downstream-blocker Blocking the downstream ecosystem to work properly (priority) labels Oct 3, 2022
Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I was going to propose the same in the other PR.

@patak-dev
Copy link
Member

/ecosystem-ci run

@vite-ecosystem-ci
Copy link

vite-ecosystem-ci bot commented Oct 3, 2022

📝 Ran ecosystem CI: Open

suite result
astro ✅ success
iles ✅ success
ladle ❌ failure
laravel ❌ failure
marko ✅ success
nuxt-framework ✅ success
rakkas ✅ success
storybook ❌ failure
svelte ✅ success
vite-plugin-ssr ❌ failure
vite-setup-catalogue ✅ success
vitepress ❌ failure
vitest ❌ failure
windicss ✅ success

@patak-dev
Copy link
Member

The failures in ecosystem-ci seem related to the current issues in the 3.2 ci (most of them are problems with the project's CIs).
Let's merge this one for 3.2. @bluwy maybe you could backport this in a PR to v3.1 and we can run /ecosystem-ci run there too? We need to work with maintainers to get back to a green state for ecosystem ci, it is quite hard to use it with so many false positives (dominikg is also working on an update that will run the project's CI without overrides after a fail so we can mark results as invalid instead of a fail)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: hmr p3-downstream-blocker Blocking the downstream ecosystem to work properly (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reload virtual module on demand
3 participants