Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ssr): track var as function scope #10388

Merged
merged 2 commits into from
Oct 9, 2022
Merged

fix(ssr): track var as function scope #10388

merged 2 commits into from
Oct 9, 2022

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Oct 9, 2022

Description

Fix #10386

var should be left as function-scope like before. only let, const (and others) are block scope.

Additional context

Once this is merged, I can cherry pick into v3.1 branch too.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

@bluwy bluwy added p3-downstream-blocker Blocking the downstream ecosystem to work properly (priority) feat: ssr labels Oct 9, 2022
Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test case is gold.

@patak-dev patak-dev merged commit 87b48f9 into main Oct 9, 2022
@patak-dev patak-dev deleted the ssr-var-scope branch October 9, 2022 19:44
bluwy added a commit to bluwy/vite that referenced this pull request Oct 10, 2022
patak-dev pushed a commit that referenced this pull request Oct 10, 2022
backport: fix(ssr): track var as function scope (#10388)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: ssr p3-downstream-blocker Blocking the downstream ecosystem to work properly (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vue2.insertAdjacentElement is not a function
2 participants