Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(css): inject source content conditionally #12449

Merged
merged 1 commit into from
Mar 16, 2023

Conversation

antfu
Copy link
Member

@antfu antfu commented Mar 16, 2023

Description

As how we handle it in JS:

if (map.mappings && !map.sourcesContent) {

We should also guard injectSourcesContent in CSS source map for virtual CSS modules

Additional context

unocss/unocss#2113 (comment)


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@stackblitz
Copy link

stackblitz bot commented Mar 16, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@patak-dev patak-dev merged commit 3e665f6 into main Mar 16, 2023
@patak-dev patak-dev deleted the fix/css-sourcemap-content branch March 16, 2023 19:20
IanVS added a commit to IanVS/vite that referenced this pull request Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants