perf: avoid new URL() in hot path

[patak-dev]

Description

@ArnaudBarre mentioned that new URL is a bottleneck in his tests. We don't really need to use new URL here because to resolve the Id we are already using cleanUrl which is a simple regex.

This path was first using parseUrl, then changed by @sapphi-red to use new URL here

• fix: prevent null pathname error #9188

@sapphi-red maybe this should also have an effect on your perf benchmark, although it should have less impact once we merge

• perf: module graph url shortcuts #12635

---

What is the purpose of this pull request?

• Bug fix
• New Feature
• Documentation update
• Other

[stackblitz]

Run & review this pull request in StackBlitz Codeflow.

[patak-dev]

@ArnaudBarre maybe you can test your own project to see if this helps you? I checked and we don't have any other new URL call in a hot path after this one.

[bluwy]

Nice refactor. I noticed URL in the cpuprofiles too.

[ArnaudBarre]

On a 3.2s timeline in speedscope (cold start):

So this is a big 1% speedup, worth it!

[sapphi-red]

Nice 👍

This reduced about 150ms.

Before

Vite  startup time: 4926ms (including server start up time: 497ms)
Vite  Root HMR time: 35ms
Vite  Leaf HMR time: 14ms
Vite (swc)  startup time: 3572ms (including server start up time: 241ms)
Vite (swc)  Root HMR time: 33ms
Vite (swc)  Leaf HMR time: 12ms

After

Vite  startup time: 4753ms (including server start up time: 485ms)
Vite  Root HMR time: 34ms
Vite  Leaf HMR time: 15ms
Vite (swc)  startup time: 3402ms (including server start up time: 237ms)
Vite (swc)  Root HMR time: 33ms
Vite (swc)  Leaf HMR time: 13ms