Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(dynamic-import): fix multiline test #12996

Merged
merged 1 commit into from
Apr 25, 2023

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Apr 25, 2023

Description

I messed up the test added in #9314 😅

This should make the multiline test work correctly. Otherwise this part

// prettier-ignore
import(
/* this messes with */
`../alias/${base}.js`
/* es-module-lexer */
).then((mod) => {
text('.dynamic-import-with-vars-multiline', mod.hello())
})

causes a runtime error in the browser.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

@bluwy bluwy added p1-chore Doesn't change code behavior (priority) test labels Apr 25, 2023
@stackblitz
Copy link

stackblitz bot commented Apr 25, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@patak-dev patak-dev merged commit 06afbfb into main Apr 25, 2023
@patak-dev patak-dev deleted the fix-dynamic-import-mutliline-test branch April 25, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1-chore Doesn't change code behavior (priority) test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants