-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): update sirv to 2.0.3 #13057
Changes from 3 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -123,8 +123,8 @@ | |
}, | ||
"patchedDependencies": { | ||
"[email protected]": "patches/[email protected]", | ||
"[email protected]": "patches/[email protected].patch", | ||
"[email protected].3": "patches/[email protected].3.patch" | ||
"[email protected]": "patches/[email protected].patch", | ||
"[email protected].3": "patches/[email protected].3.patch" | ||
} | ||
}, | ||
"stackblitz": { | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -43,14 +43,12 @@ describe.runIf(isServe)('main', () => { | |
}) | ||
|
||
test('unsafe fetch with special characters (#8498)', async () => { | ||
expect(await page.textContent('.unsafe-fetch-8498')).toMatch( | ||
'403 Restricted', | ||
) | ||
expect(await page.textContent('.unsafe-fetch-8498-status')).toBe('403') | ||
expect(await page.textContent('.unsafe-fetch-8498')).toBe('') | ||
expect(await page.textContent('.unsafe-fetch-8498-status')).toBe('404') | ||
}) | ||
|
||
test('unsafe fetch with special characters 2 (#8498)', async () => { | ||
expect(await page.textContent('.unsafe-fetch-8498-2')).toMatch('') | ||
expect(await page.textContent('.unsafe-fetch-8498-2')).toBe('') | ||
Comment on lines
-53
to
+51
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. IIUC This line wasn't testing anything. 😅 |
||
expect(await page.textContent('.unsafe-fetch-8498-2-status')).toBe('404') | ||
}) | ||
|
||
|
@@ -78,7 +76,7 @@ describe.runIf(isServe)('main', () => { | |
|
||
test('unsafe fs fetch with special characters (#8498)', async () => { | ||
expect(await page.textContent('.unsafe-fs-fetch-8498')).toBe('') | ||
expect(await page.textContent('.unsafe-fs-fetch-8498-status')).toBe('403') | ||
expect(await page.textContent('.unsafe-fs-fetch-8498-status')).toBe('404') | ||
}) | ||
|
||
test('unsafe fs fetch with special characters 2 (#8498)', async () => { | ||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part was returning
%2Ffoo%2Fbar
whenurl.pathname
was/foo/bar
. But because lukeed/sirv#149 changeddecodeURIComponent
todecodeURI
, this no longer works.The reason why this part was using
encodeURIComponent
is #8979. In that time, we weren't able to usedecodeURI
in line 162 because of #8804.