Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: link to ko translation #13285

Merged
merged 1 commit into from
Jun 8, 2023
Merged

docs: link to ko translation #13285

merged 1 commit into from
Jun 8, 2023

Conversation

Gumball12
Copy link
Member

@Gumball12 Gumball12 commented May 21, 2023

Description

Korean translation is now available. This PR is to add a link to the Korean docs to the English docs.

This documentation is being kept up to date using GitHub Actions.

Additional context

vite-docs-template says that I need to transfer the translation repository to the Vite organization. The vitejs-kr.github.io repository is ready for this, but I'm not sure how to proceed with the next step. Can you help?


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@stackblitz
Copy link

stackblitz bot commented May 21, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@patak-dev
Copy link
Member

Hey @Gumball12! Awesome work with the translation!

I see you are already in the #docs channel at https://chat.vitejs.dev? we can discuss there the details of the transfer. Thanks for your efforts to make Vite docs more accessible!

@patak-dev
Copy link
Member

We discussed with @Gumball12 in Discord, and now the repo has been transferred to https://github.com/vitejs/docs-kr. Let's merge this PR once we have the kr. subdomain setup.

@patak-dev
Copy link
Member

@Gumball12 @userquin I'm checking the codes at https://en.wikipedia.org/wiki/List_of_ISO_639-1_codes

I think we should use ko for Korean instead of kr, no? I'll rename the transferred repo if that is the case.

We currently have: cn (Chinese, maybe it should have been zh?), ja (Japanese), es (Spanish), pt (Portuguese)

@Gumball12
Copy link
Member Author

Gumball12 commented May 23, 2023

@patak-dev Yes, I think so too, thanks!

@userquin
Copy link
Contributor

I think we should use ko for Korean instead of kr, no? I'll rename the transferred repo if that is the case.
We currently have: cn (Chinese, maybe it should have been zh?), ja (Japanese), es (Spanish), pt (Portuguese)

Instead of using any nomenclature LGTM using ISO-639-2: vue docs doesn't use ISO-639-2

@patak-dev
Copy link
Member

We aren't going to change the current docs though, so I'm proposing we stick to 639-1 (the two letters codes). The only one that would be wrong there is cn, but that's ok.

@Gumball12
Copy link
Member Author

Has anything been updated? If there's something I've missed, please let me know :)

@patak-dev
Copy link
Member

No, sorry, I haven't asked yet until we define the right name for the subdomain. I missed Joaquin's thumbs-up, thanks for the heads-up. I'll ask Evan once he is back home from Render ATL to do the setup, nothing is needed from your side Gumball12.

@patak-dev
Copy link
Member

Evan created the ko subdomain, already working at https://ko.vitejs.dev
Thanks again @Gumball12! Let's merge this PR and we'll release the docs update linking to the new translation as part of Vite 4.4.

@patak-dev patak-dev merged commit 93eed46 into vitejs:main Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants