Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused packages #14310

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

sapphi-red
Copy link
Member

Description

Removed unused packages from package.json.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p1-chore Doesn't change code behavior (priority) label Sep 6, 2023
@stackblitz
Copy link

stackblitz bot commented Sep 6, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@@ -46,7 +46,6 @@
"@rollup/plugin-typescript": "^11.1.2",
"@types/babel__core": "^7.20.1",
"@types/babel__preset-env": "^7.9.2",
"@types/babel__standalone": "^7.1.4",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@babel/standalone was used by plugin-legacy in past. But now it uses @babel/core.

@@ -15,7 +15,6 @@
"vue-router": "^4.2.4"
},
"devDependencies": {
"@vitejs/plugin-vue": "^4.2.3",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to remove in #14073

@sapphi-red
Copy link
Member Author

Node.js 20 is failing with the same reason with #14307 (comment)

@sapphi-red sapphi-red merged commit 4fb617f into vitejs:main Sep 7, 2023
9 of 10 checks passed
@sapphi-red sapphi-red deleted the chore/remove-unused-package branch September 7, 2023 08:17
Gaubee pushed a commit to Gaubee/vite that referenced this pull request Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1-chore Doesn't change code behavior (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants