Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(resolve): make directory package.json check best effort #14626

Merged
merged 2 commits into from
Oct 23, 2023

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Oct 14, 2023

Description

fix #6894
fix #6859

During path resolving, for directory imports, if the directory has package.json but it doesn't resolve to anything (e.g. no main etc), skip the resolve error and continue trying other ways to resolve. The current logic insists that it must resolve to something.

The issues above show how this sometimes indirectly affect URLs. One way to test this is by visiting http://localhost:5173/path/to/local/vite (e.g. http://localhost:5173/Users/bjorn/Work/oss/vite)

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added the p3-minor-bug An edge case that only affects very specific usage (priority) label Oct 14, 2023
@patak-dev patak-dev merged commit d520388 into main Oct 23, 2023
10 checks passed
@patak-dev patak-dev deleted the resolve-package-json branch October 23, 2023 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
2 participants