Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ssr): backport ssr.resolve.conditions and ssr.resolve.externalConditions (#14498) #14668

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

patak-dev
Copy link
Member

Description

Backport #14498 to v4. We can discuss here if we should move forward with it. We can release it under a v4 minor if we merge it. A few downstream projects awaiting this feature: #14498 (comment)


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

const resolveOptions: InternalResolveOptions = {
...config.resolve,
root,
isProduction: false,
isBuild: true,
conditions: targetConditions,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line can be thought as a breaking change (previously resolve.conditions were used, but now ssr.resolve.externalConditions will be used). But I guess it wouldn't cause any problems.

@patak-dev patak-dev merged commit 520139c into v4 Oct 18, 2023
15 checks passed
@patak-dev patak-dev deleted the feat/port-14498 branch October 18, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants