fix(css): fix sourcemap warning in build with lightningCSS #14871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArnaudBarre
added
the
p3-minor-bug
|
|
sapphi-red
reviewed
Nov 4, 2023
Comment on lines
2276
to
2278
| sourceMap: config.isProduction | ||
| ? !!config.build.sourcemap | ||
| : config.css?.devSourcemap, |
There was a problem hiding this comment.
config.isProduction doesn't mean it's in vite build (e.g. NODE_ENV=development vite build). So I think using config.command === 'build' is correct here.
But given that CSS sourcemaps in build is not supported yet (#2830), does this fix anything? (I think we can still have it but it's chore: than a fix: in that case)
There was a problem hiding this comment.
This fixes annoying warning 'vite:css didn't provide source map' when using source map in production but not devSourcemap
sapphi-red
approved these changes
Nov 4, 2023
ArnaudBarre
changed the title
bluwy
approved these changes
Nov 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.